Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove POSTGRES_PASSWORD variable in compose file #483

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Jan 15, 2025

Fixes #482. Remove POSTGRES_PASSWORD variable in compose file.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Fixes edgexfoundry#482. Remove POSTGRES_PASSWORD variable in compose file.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose.yml should also be updated

Remove POSTGRES_PASSWORD in docker-compose.yml.

Signed-off-by: Lindsey Cheng <[email protected]>
@lindseysimple
Copy link
Contributor Author

recheck

2 similar comments
@lindseysimple
Copy link
Contributor Author

recheck

@cloudxxx8
Copy link
Member

recheck

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit feff445 into edgexfoundry:main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Postgres POSTGRES_PASSWORD env variable in compose file with security enabled
2 participants